Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bats-lib methods from central repo #150

Merged
merged 2 commits into from
Aug 18, 2020
Merged

Added bats-lib methods from central repo #150

merged 2 commits into from
Aug 18, 2020

Conversation

garethahealy
Copy link
Contributor

What is this PR About?

Updated the conftest/bats bits to use the CoP bats lib.

How do we test this?

Action!

or

bats _test/conftest.sh

Who would you like to review this?

cc: @redhat-cop/containers-approvers

@garethahealy
Copy link
Contributor Author

the CI has failed because this repo contains BuildConfigs with jenkinsPipelineStrategy - can either:

  • skip the tests which contains those bits
  • ignore that policy via get_namespace using regex
  • or remove/replace those BCs

thoughts?

Copy link
Contributor

@pabrahamsson pabrahamsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @garethahealy
/lgtm

@redhat-cop-ci-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pabrahamsson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@redhat-cop-ci-bot redhat-cop-ci-bot merged commit 44784ed into redhat-cop:master Aug 18, 2020
@garethahealy garethahealy deleted the bats branch March 31, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants